Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #19 - config_backup() is a function instead property #20

Merged
merged 1 commit into from
Dec 15, 2016

Conversation

tchellomello
Copy link
Owner

Fixed issue #19 that should be a function instead a @Property

» amcrest-cli  --camera amcrestcam1 --config-backup --save /tmp/cfg                                                                                 ~/d/h/homeassistant
Traceback (most recent call last):
  File "/home/mdemello/.virtualenvs/home_assistant/bin/amcrest-cli", line 863, in <module>
    main()
  File "/home/mdemello/.virtualenvs/home_assistant/bin/amcrest-cli", line 849, in main
    camera.config_backup(args.save)
TypeError: 'str' object is not callable

After applying the fix:

~ » amcrest-cli --camera amcrestcam1  --config-backup --save /tmp/lala22.txt 
~ » ls -la /tmp/lala22.txt                    
-rw-rw-r--. 1 user user 154734 Dec 14 19:23 /tmp/lala22.txt

@mention-bot
Copy link

@tchellomello, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dougsland to be a potential reviewer.

@tchellomello tchellomello self-assigned this Dec 15, 2016
@tchellomello tchellomello merged commit 0b2a406 into master Dec 15, 2016
@tchellomello tchellomello deleted the issue_19 branch December 15, 2016 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants