Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 5 commits
- 4 files changed
- 1 contributor
Commits on Mar 13, 2022
-
Raise timeout exception from async stream
Using httpx, the `.stream` method does not raise an exception when the device goes offline if the read timeout is disabled. To get around this, introduce a new exception that will be thrown if a timeout is hit so it can more easily be handled and the stream reconnected as needed. Add handling logic to the async_event_stream so it behaves like the non-async method by retrying while read errors are thrown.
-
Merge pull request #211 from flacjacket/add_timeout
Raise timeout exception from async stream
-
It looks like the first two characters after the ContentLength is specified are a carriage return. This has thrown off the json string parsing leading to hand rolling regex which fails in odd ways (see #204). Now, pull out a couple extra characters to get past this leading carriage return. If the leading characters are not there, we should have a trailing \r\n\r\n which is safe to add, and will just be stripped out. With this change in place, we are able to use json parsing on data, with a fallback to sending the data string.
-
Merge pull request #212 from flacjacket/event_parse
Improve event data handling
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1.9.5...1.9.6