Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] an option to not create a start menu folder for nsis installer #9880

Closed
Legend-Master opened this issue May 25, 2024 · 5 comments · Fixed by #9994
Closed

[feat] an option to not create a start menu folder for nsis installer #9880

Legend-Master opened this issue May 25, 2024 · 5 comments · Fixed by #9994

Comments

@Legend-Master
Copy link
Contributor

Legend-Master commented May 25, 2024

Describe the problem

We currently use nsis's built-in start menu shortcut folder picker and put the shortcut in that folder, and most of the times, user will just spam next and resulting app/app.exe in the start menu, it's pretty weird to put a single shortcut inside of a folder for me

And also, I don't think most end users understand what shortcut menu is and that page is always a source of confusion (I didn't know what that is after using Windows for 10 years before I started really learning those things myself at least)

Describe the solution you'd like

Add an option to skip that picker page and just put the shortcut in the start menu without the folder, to be honest, I think it should even be the default

Alternatives considered

Doing it manually with custom template

Additional context

A simple comparison (not produced by tauri's nsis installer, just as a visual reference)

image
image

@FabianLars
Copy link
Member

I think it should even be the default

Agreed.

@amrbashir
Copy link
Member

The reason I went with that, is because on newer Win11 (and maybe newer versions of Win10) automatically detects that it only has one shortcut and will display it without a folder, what is your OS version?

@Legend-Master
Copy link
Contributor Author

Legend-Master commented May 28, 2024

I'm on latest Windows 10 19045.4412, to be honest, I'm more about the confusion around it, most people understand desktop shortcuts but not start menu shortcuts, especially it shows you a list of folders and let you pick one...

@amrbashir
Copy link
Member

I guess we can remove the directory and just keep the shortcut.

I think the idea was if a user has multiple apps from the same publisher, they are grouped under one directory, like Riot Games, install their games shortcuts under one directory called Riot Games.

image

Anyways, I have no preference here, I am fine with both.

@Legend-Master
Copy link
Contributor Author

Legend-Master commented May 28, 2024

I think the idea was if a user has multiple apps from the same publisher, they are grouped under one directory

Yeah, but I think we currently use the product name as that folder name?

Anyways, I have no preference here, I am fine with both.

Cool, I'll make a PR then

I think NSIS did this because you might want to put more shortcuts in that folder, but in our case, we don't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants