Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] nsis deep link doesn't work #10095

Closed
thewh1teagle opened this issue Jun 19, 2024 · 2 comments
Closed

[bug] nsis deep link doesn't work #10095

thewh1teagle opened this issue Jun 19, 2024 · 2 comments
Assignees
Labels
platform: Windows status: needs triage This issue needs to triage, applied to new issues type: bug

Comments

@thewh1teagle
Copy link
Contributor

thewh1teagle commented Jun 19, 2024

Describe the bug

When using deep link plugin in v2 project and adding desktop deep link schemas in tauri.conf.json the deep link doesn't work with nsis target while with msi it work.

Reproduction

  1. Add deep link plugin and single-instance (I use both)
  2. Add plugins config to tauri conf
  "plugins": {
    "deep-link": {
      "mobilde": {},
      "desktop": {
        "schemas": ["deep"]
      }
    }
  },
  1. Build the app and install nsis installer.
  2. Paste in console in browser:
location.href = "deep:https://test"

Notice the error.
5. Install msi target and try again and see that it works.

Expected behavior

It should open the app with that schema for nsis

Full tauri info output

[✔] Environment
    - OS: Windows 10.0.22631 X64
    ✔ WebView2: 126.0.2592.61
    ✔ MSVC: Visual Studio Community 2022
    ✔ rustc: 1.77.1 (7cf61ebde 2024-03-27)
    ✔ cargo: 1.77.1 (e52e36006 2024-03-26)
    ✔ rustup: 1.27.0 (bbb9276d2 2024-03-08)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 20.12.0
    - npm: 10.5.0
    - bun: 1.1.10

[-] Packages
    - tauri [RUST]: 2.0.0-beta.22
    - tauri-build [RUST]: 2.0.0-beta.17
    - wry [RUST]: 0.40.1
    - tao [RUST]: 0.28.1
    - @tauri-apps/api : not installed!
    - @tauri-apps/cli [NPM]: 2.0.0-beta.20

[-] App
    - build-type: bundle
    - CSP: unset

Stack trace

No response

Additional context

I implemented it and register it in runtime with no admin rights and it works!
see src-tauri/src/register_custom_protocol.rs

There's option to create runtime api in Windows
https://stackoverflow.com/questions/80650/how-do-i-register-a-custom-url-protocol-in-windows

https://stackoverflow.com/questions/45809064/registering-custom-protocol-at-installation-process-in-electron-app

After review cli code, looks like it simply doesn't implemented for nsis

@thewh1teagle thewh1teagle added status: needs triage This issue needs to triage, applied to new issues type: bug labels Jun 19, 2024
@FabianLars FabianLars self-assigned this Jun 20, 2024
@Legend-Master
Copy link
Contributor

Legend-Master commented Jun 23, 2024

I can not reproduce this using API example in current head with this configuration

"deep-link": {
  "desktop": {
    "schemes": ["my-tauri-app"]
  }
}
nsis-deep-link.mp4

But I found another bug, the current uninstaller can't remove the deep link it registered 😂 (just opened a PR for that #10103)

@amrbashir
Copy link
Member

closing this as it can't be reproduced, if the issue still exists, please provide a minimal repro

@amrbashir amrbashir closed this as not planned Won't fix, can't repro, duplicate, stale Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Windows status: needs triage This issue needs to triage, applied to new issues type: bug
Projects
None yet
Development

No branches or pull requests

4 participants