Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for z flip 5 cover screen #2843

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

liz-desartiges
Copy link
Contributor

@liz-desartiges
Copy link
Contributor Author

liz-desartiges commented Apr 15, 2024

just tested it doesn't seams that we actually need to enforce the size of the widget to be 352dpx339dp, it just work like that

one thing to improve is to be able to edit settings of the widget without unfolding the phone, I'll have a look at this later

@liz-desartiges
Copy link
Contributor Author

editing settings inside the widget works, but editing them via the editing settings in the cover screen ui ask from the user to open their phone, this is what I will have to look into

@abaker
Copy link
Member

abaker commented Apr 18, 2024

Thanks for the PR! I can't test this myself, but it's good to merge?

@liz-desartiges
Copy link
Contributor Author

liz-desartiges commented Apr 21, 2024

Yeah I've been using it daily since, there is one thing I haven't figured out but that could totally come in a second mr. Which is setting which screen should display the widget option when they are accessed from the cover screen settings, they work just fine from the gear within the widget itself, but I couldn't tell were I can set ActivityOptions before displaying the widget settings

@abaker abaker merged commit ffc0113 into tasks:main Apr 22, 2024
5 checks passed
@abaker
Copy link
Member

abaker commented Apr 22, 2024

editing settings inside the widget works, but editing them via the editing settings in the cover screen ui ask from the user to open their phone, this is what I will have to look into

Are you saying that clicking on the gear icon in the widget header works, but editing a widget from main app settings > widget settings doesn't work? Or long pressing on the widget to use the system UI to open up the edit screen?

@liz-desartiges
Copy link
Contributor Author

This is easier to explain with a video :

Screen_Recording_20240422_175345_Proton.Mail.mp4

So when you click the gear icon you can edit the settings on the cover screen.

But when you use the system widget settings like at the end of the video you are asked to open your phone, and when you open it you can manage your settings on the main display. But I find this cumbersome and would rather have the same behavior as the gear button within the widget

I hope it makes more sense explained this way

@abaker
Copy link
Member

abaker commented Apr 23, 2024

Thanks for the video, that is what I thought you were talking about. My guess is that there is no solution to that problem - that edit button is a system thing and its launching the activity specified in the appwidget-provider

@cankurttekin
Copy link

i just realized there is a new Tasks widget available on cover screen and i immediately added it. ive been taking screenshot and setting as cover screen wallpaper before than which sucks and look bad. Iireally appreciate this feature indeed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants