Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemere: improved OpenTelemetry interop #16

Closed
ptaoussanis opened this issue May 8, 2024 · 6 comments
Closed

Telemere: improved OpenTelemetry interop #16

ptaoussanis opened this issue May 8, 2024 · 6 comments
Assignees
Labels
can close? Can be closed? input/help welcome Assistance and/or ideas welcome

Comments

@ptaoussanis
Copy link
Member

Task: Look for opportunities to improve Telemere's OpenTelemetry support - incl. first-class conveyance of Telemere's trace info, etc.

Motivation: Telemere already supports basic interop with OpenTelemetry via its OpenTelemetry logging handler, but there's probably further opportunities to convey more information (notably Telemere spans) to OpenTelemetry in a way that better allows it to digest this info.

Pointers to relevant docs, etc. would be helpful if you have them!

@robert-stuttaford
Copy link

Watching Telemere with keen interest :-D We use Timbre for logging today, and have big plans to make use of Honeycomb in our next arc of observability work (we use https://github.com/steffan-westcott/clj-otel for our experiments at the moment).

Telemere looks like it would fit very neatly into our plans!

@duzunov
Copy link

duzunov commented May 14, 2024

I would be very happy to test OTel support in Telemere

@emowcee
Copy link

emowcee commented May 15, 2024

Really interested to see where the otel thread is leading! Following

@ptaoussanis ptaoussanis self-assigned this Aug 7, 2024
@ptaoussanis ptaoussanis added the underway Work is underway (work in progress) label Aug 18, 2024
@ptaoussanis
Copy link
Member Author

ptaoussanis commented Aug 19, 2024

Hi folks! 👋 I've just pushed Telemere v1 beta 18 to Clojars.

This includes the first experimental support for automatically emitting correlated logs and tracing data to OpenTelemetry.

See here for info on getting started. There's no special usage instructions - in principle you should just be able to use the regular Telemere API as always, and your signals will just be auto-converted in an appropriate way.

I'm not a big user of OpenTelemetry myself, so will definitely need help with testing and feedback from folks interested in this feature! 🙏 The kinds of feedback I'm looking for include:

  • Usage reports (is everything working correctly, is it intuitive, etc.?)
  • Feedback on output (how are the attribute names, coercions, etc.?)
  • Any limitations (anything you want to do but can't?)
  • Any other thoughts or suggestions! Now's the perfect time to get changes in, before Telemere itself is marked as stable.

The best places to leave feedback:

Thanks! Cheers :-)

@ptaoussanis ptaoussanis added the input/help welcome Assistance and/or ideas welcome label Aug 19, 2024
@ptaoussanis
Copy link
Member Author

Update: v1 beta 21 is now on Clojars and includes improved integration with OpenTelemetry tracing.

Telemere's tracing forms now emit code that interops directly with the OpenTelemetry tracing API when it’s present. This means that Telemere spans will show as expected within spans created by other (auto/manual) OpenTelemetry tools, and vice versa.

Barring any unexpected issues or suggested changes, this feature should now basically be complete.

@ptaoussanis ptaoussanis added can close? Can be closed? and removed underway Work is underway (work in progress) labels Aug 26, 2024
@ptaoussanis
Copy link
Member Author

Closing for now, but please feel free to ping if anyone runs into issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can close? Can be closed? input/help welcome Assistance and/or ideas welcome
Projects
None yet
Development

No branches or pull requests

4 participants