From 7198b1642a948c6ee90118e694cd43e6f280ff28 Mon Sep 17 00:00:00 2001 From: kxz Date: Mon, 8 Apr 2024 03:51:26 +0530 Subject: [PATCH 1/8] fix: `start-database.sh` is marked optional --- cli/src/helpers/logNextSteps.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cli/src/helpers/logNextSteps.ts b/cli/src/helpers/logNextSteps.ts index 60df878de7..a100b98710 100644 --- a/cli/src/helpers/logNextSteps.ts +++ b/cli/src/helpers/logNextSteps.ts @@ -1,3 +1,5 @@ +import chalk from "chalk"; + import { DEFAULT_APP_NAME } from "~/consts.js"; import { type InstallerOptions } from "~/installers/index.js"; import { getUserPkgManager } from "~/utils/getUserPkgManager.js"; @@ -35,7 +37,7 @@ export const logNextSteps = async ({ } if (["postgres", "mysql"].includes(databaseProvider)) { - logger.info(" ./start-database.sh"); + logger.info(` ./start-database.sh (${chalk.red("Optional")})`); } if (packages?.prisma.inUse || packages?.drizzle.inUse) { From b563e3010baa1c737e67defacb683b806c36fad9 Mon Sep 17 00:00:00 2001 From: kxz Date: Mon, 8 Apr 2024 07:10:05 +0530 Subject: [PATCH 2/8] db down instruction update --- cli/src/helpers/logNextSteps.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/src/helpers/logNextSteps.ts b/cli/src/helpers/logNextSteps.ts index a100b98710..4fb545880c 100644 --- a/cli/src/helpers/logNextSteps.ts +++ b/cli/src/helpers/logNextSteps.ts @@ -37,7 +37,7 @@ export const logNextSteps = async ({ } if (["postgres", "mysql"].includes(databaseProvider)) { - logger.info(` ./start-database.sh (${chalk.red("Optional")})`); + logger.info(` ${chalk.red("If db is down")}, use ./start-databse.sh`); } if (packages?.prisma.inUse || packages?.drizzle.inUse) { From ffe64c14920617842210e9db424403a42aaaa611 Mon Sep 17 00:00:00 2001 From: kxz <63444697+kxzazz@users.noreply.github.com> Date: Mon, 8 Apr 2024 16:20:44 +0530 Subject: [PATCH 3/8] Update cli/src/helpers/logNextSteps.ts Co-authored-by: Julius Marminge --- cli/src/helpers/logNextSteps.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/src/helpers/logNextSteps.ts b/cli/src/helpers/logNextSteps.ts index 4fb545880c..89ad97aa41 100644 --- a/cli/src/helpers/logNextSteps.ts +++ b/cli/src/helpers/logNextSteps.ts @@ -37,7 +37,7 @@ export const logNextSteps = async ({ } if (["postgres", "mysql"].includes(databaseProvider)) { - logger.info(` ${chalk.red("If db is down")}, use ./start-databse.sh`); + logger.info(` Start up a database, for example using './start-databse.sh'`); } if (packages?.prisma.inUse || packages?.drizzle.inUse) { From 666ae38445eba2a3015b7b9abe371eaf0ab4b318 Mon Sep 17 00:00:00 2001 From: kxz <63444697+kxzazz@users.noreply.github.com> Date: Mon, 8 Apr 2024 16:21:00 +0530 Subject: [PATCH 4/8] Update cli/src/helpers/logNextSteps.ts Co-authored-by: Julius Marminge --- cli/src/helpers/logNextSteps.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/cli/src/helpers/logNextSteps.ts b/cli/src/helpers/logNextSteps.ts index 89ad97aa41..6c182faf62 100644 --- a/cli/src/helpers/logNextSteps.ts +++ b/cli/src/helpers/logNextSteps.ts @@ -1,5 +1,3 @@ -import chalk from "chalk"; - import { DEFAULT_APP_NAME } from "~/consts.js"; import { type InstallerOptions } from "~/installers/index.js"; import { getUserPkgManager } from "~/utils/getUserPkgManager.js"; From f13146868db4e775947e2ce2a51ae31a5292f58a Mon Sep 17 00:00:00 2001 From: kxz Date: Mon, 8 Apr 2024 16:25:35 +0530 Subject: [PATCH 5/8] remove red --- cli/src/helpers/logNextSteps.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cli/src/helpers/logNextSteps.ts b/cli/src/helpers/logNextSteps.ts index 6c182faf62..71385cc450 100644 --- a/cli/src/helpers/logNextSteps.ts +++ b/cli/src/helpers/logNextSteps.ts @@ -35,7 +35,9 @@ export const logNextSteps = async ({ } if (["postgres", "mysql"].includes(databaseProvider)) { - logger.info(` Start up a database, for example using './start-databse.sh'`); + logger.info( + " Start up a database, for example using './start-databse.sh'" + ); } if (packages?.prisma.inUse || packages?.drizzle.inUse) { From 7163f8e3af05533d03cf22387198ae5806315deb Mon Sep 17 00:00:00 2001 From: kxz Date: Mon, 8 Apr 2024 16:31:45 +0530 Subject: [PATCH 6/8] optional `start-databse.sh` --- cli/src/helpers/logNextSteps.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/cli/src/helpers/logNextSteps.ts b/cli/src/helpers/logNextSteps.ts index 71385cc450..e95d2da66a 100644 --- a/cli/src/helpers/logNextSteps.ts +++ b/cli/src/helpers/logNextSteps.ts @@ -35,9 +35,7 @@ export const logNextSteps = async ({ } if (["postgres", "mysql"].includes(databaseProvider)) { - logger.info( - " Start up a database, for example using './start-databse.sh'" - ); + logger.info(" Start up a database, if needed using './start-databse.sh'"); } if (packages?.prisma.inUse || packages?.drizzle.inUse) { From 8374cd801e71375bd4af39d43d0d251fe3ca0293 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Mon, 8 Apr 2024 13:05:55 +0200 Subject: [PATCH 7/8] Create beige-pets-yell.md --- .changeset/beige-pets-yell.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/beige-pets-yell.md diff --git a/.changeset/beige-pets-yell.md b/.changeset/beige-pets-yell.md new file mode 100644 index 0000000000..d7b8c3b01a --- /dev/null +++ b/.changeset/beige-pets-yell.md @@ -0,0 +1,5 @@ +--- +"create-t3-app": patch +--- + +fix: `start-database.sh` is marked optional From 57bb0189e06fc4585c02d2cf7c28afe05da97a9f Mon Sep 17 00:00:00 2001 From: kxz Date: Mon, 8 Apr 2024 16:40:57 +0530 Subject: [PATCH 8/8] typo fixed --- cli/src/helpers/logNextSteps.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/src/helpers/logNextSteps.ts b/cli/src/helpers/logNextSteps.ts index e95d2da66a..98cedfbc74 100644 --- a/cli/src/helpers/logNextSteps.ts +++ b/cli/src/helpers/logNextSteps.ts @@ -35,7 +35,7 @@ export const logNextSteps = async ({ } if (["postgres", "mysql"].includes(databaseProvider)) { - logger.info(" Start up a database, if needed using './start-databse.sh'"); + logger.info(" Start up a database, if needed using './start-database.sh'"); } if (packages?.prisma.inUse || packages?.drizzle.inUse) {