Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add clerk to cli init tool #1418

Closed
wants to merge 7 commits into from

Conversation

Sn0wye
Copy link
Contributor

@Sn0wye Sn0wye commented May 14, 2023

Closes #1409

✅ Checklist

WIP

  • I have followed every step in the contributing guide (updated 2022-10-06).

  • I performed a functional test on my final commit

  • The PR title follows the convention we established conventional-commit

  • Clerk Installer (including middleware)

  • tRPC Installer

Templates

tRPC

  • src/server/api/trpc.ts
  • src/server/api/routers/example.ts

Middleware

  • src/middleware.ts

Boilerplates

  • src/pages/_app.tsx
  • src/pages/index.tsx

Unresolved

  • block NextAuth when Clerk is selected

Changelog

[Short description of what has changed]


Screenshots

[Screenshots]

💯

@changeset-bot
Copy link

changeset-bot bot commented May 14, 2023

⚠️ No Changeset found

Latest commit: 8a0dc19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 14, 2023

@Sn0wye is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented May 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2023 7:23pm

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-git-fork-sn0wye-feat-add-clerk-t3-oss.vercel.app/

@Sn0wye Sn0wye changed the title feat: add clerk to cli init tool feat(cli): add clerk to cli init tool May 14, 2023
@FleetAdmiralJakob
Copy link

After you resolved the other issues, you could add Clerk also to the T3 Website

@Sn0wye
Copy link
Contributor Author

Sn0wye commented May 18, 2023

Of course i'll do!

@c-ehrlich
Copy link
Member

We are not looking to add Clerk to the core stack at the moment.

Really sorry for closing this after it's already basically complete.

The reason is that the core of the T3 Stack should always remain free to use. As much as we like Clerk, we don't want to include a library that is tied to a paid service.

We have talked a few times about maybe building an "add-on" system in the future, and we would consider Clerk for this. If we ever get to that point (it's all just an idea currently) we'd be happy for you to build the one for Clerk (or anything else!).

Again sorry for closing this after you've already put so much work into it.

@c-ehrlich c-ehrlich closed this May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(cli): add clerk
3 participants