Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor bug: next-auth.d.ts gets added to tsconfig.json even if I don't select it when setting up the proejct. #343

Closed
timfee opened this issue Aug 22, 2022 · 1 comment · Fixed by #345
Labels
🌟 enhancement New feature or request

Comments

@timfee
Copy link

timfee commented Aug 22, 2022

Provide environment information

  System:
    OS: macOS 12.5.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 290.83 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.17.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 8.15.0 - /usr/local/bin/npm

Describe the bug

It seems that next-auth.d.ts gets added to tsconfig.json's includes no matter what. I wouldn't expect that entry to exist in tsconfig.json if I don't select it when setting up the project.

To reproduce

  1. Set up project as follows:
    Screenshot_2022-08-21_17-08-40_KLAbg6wX
  2. Open tsconfig.json and observe the extra entry:
"include": [
    "next-auth.d.ts",  // <- don't expect this
    "**/*.ts",
    "**/*.tsx",
    "**/*.js",
  ],

Additional information

I know it's super nitpicky and probably doesn't cause any huge issues, but noticed it when I was debugging a related issue :)

@juliusmarminge
Copy link
Member

I don't think this entry is needed at all anymore since we moved the file into src/types, should be picked up by the **/*.ts glob pattern?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants