Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting a "EINVALIDPACKAGENAME" on fresh install #219

Closed
amyisdev opened this issue Jul 19, 2022 · 5 comments · Fixed by #220
Closed

Getting a "EINVALIDPACKAGENAME" on fresh install #219

amyisdev opened this issue Jul 19, 2022 · 5 comments · Fixed by #220
Labels
🔰 good first issue Good for newcomers ❗ high priority 🐞 confirmed bug Something isn't working

Comments

@amyisdev
Copy link
Contributor

amyisdev commented Jul 19, 2022 •
edited
Loading

Describe the bug
After a fresh t3 install using the latest version, npm install fails because of invalid package name "[email protected]".

To Reproduce
Steps to reproduce the behavior:

  1. Run npx create-t3-app@latest
  2. Answer no to run npm install
  3. Then manually run it

Expected behavior
Dependencies should be installed with no failure

Screenshots
image
@juliusmarminge
Copy link
Member

Weird. Tested this out yesterday and was working fine.

Can you verify the version of:

  • create-t3-app (npx create-t3-app --version)
  • Node
  • npm

@juliusmarminge
Copy link
Member

Either answer yes to run npm install or manually run it

On second thought I believe this is incorrect and that this is a bug with the noInstall flag. Also test answering yes when prompted in the CLI.

@amyisdev
Copy link
Contributor Author

On second thought I believe this is incorrect and that this is a bug with the noInstall flag. Also test answering yes when prompted in the CLI.

Ah, my bad. You are right, looks like it only fails with the noInstall flag.

@juliusmarminge
Copy link
Member

juliusmarminge commented Jul 19, 2022 •
edited
Loading

This is the failing line:

create-t3-app/src/utils/runPkgManagerInstall.ts

Line 41 in cf7be5a

pkgJson.dependencies![pkg] = `^${latestVersion.trim()}`; //eslint-disable-line @typescript-eslint/no-non-null-assertion

This was introduced last night when locking the react-query to version 3:

create-t3-app/src/installers/trpc.ts

Line 13 in cf7be5a

"[email protected]",

We need to handle the case where the pkg already contains a version so that it isn’t included as the package’s name when added as a dependency.

Can fix it tonight if noone files a PR before then.

@amyisdev amyisdev mentioned this issue Jul 19, 2022
Merged
3 tasks
@juliusmarminge
Copy link
Member

Will publish 5.1.2 tonight containing the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔰 good first issue Good for newcomers ❗ high priority 🐞 confirmed bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle pkg with version in noInstall mode
2 participants
@juliusmarminge @amyisdev