Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve "error" in start-database.sh when password is still default #1929

Closed
TheDevilOnLine opened this issue Jul 2, 2024 · 1 comment · Fixed by #1940
Closed

feat: Improve "error" in start-database.sh when password is still default #1929

TheDevilOnLine opened this issue Jul 2, 2024 · 1 comment · Fixed by #1940
Labels
🔰 good first issue Good for newcomers 🌟 enhancement New feature or request 👨‍👦‍👦free for all Anyone is free to take on this issue and file a PR

Comments

@TheDevilOnLine
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When you run start-database.sh, but haven't changed the password in .env from password to something else, the error says Please set a password in the .env file and try again, but this isn't really descriptive of what should be done.

Yes it says You are using the default database password before asking if you want to use the default password, but a lot of people will not read this.

Describe the solution you'd like to see

Change the error message to something like Please change the default password in the .env file and try again

Describe alternate solutions

Generate a random password in .env when generating the project

Additional information

#1927 is losely related to this as well.

@TheDevilOnLine TheDevilOnLine added the 🌟 enhancement New feature or request label Jul 2, 2024
@juliusmarminge juliusmarminge added 🔰 good first issue Good for newcomers 👨‍👦‍👦free for all Anyone is free to take on this issue and file a PR labels Jul 4, 2024
@KrishanGoyal1
Copy link
Contributor

@juliusmarminge fixed this, kindly review!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔰 good first issue Good for newcomers 🌟 enhancement New feature or request 👨‍👦‍👦free for all Anyone is free to take on this issue and file a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants