Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make it clear start-database.sh is optional #1805

Closed
juliusmarminge opened this issue Mar 18, 2024 · 0 comments · Fixed by #1817
Closed

make it clear start-database.sh is optional #1805

juliusmarminge opened this issue Mar 18, 2024 · 0 comments · Fixed by #1817
Labels
👨‍👦‍👦free for all Anyone is free to take on this issue and file a PR

Comments

@juliusmarminge
Copy link
Member

Provide environment information

Describe the bug

The start-database script is a completely optional piece but the current logNextSteps doesnt make any note about this:

create-t3-app/cli/src/helpers/logNextSteps.ts

Lines 37 to 39 in 41380d1

if (["postgres", "mysql"].includes(databaseProvider)) {
logger.info(" ./start-database.sh");
}

Reproduction repo

To reproduce

Additional information

No response
@juliusmarminge juliusmarminge added the 👨‍👦‍👦free for all Anyone is free to take on this issue and file a PR label Mar 18, 2024
@kxzazz kxzazz mentioned this issue Apr 7, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👨‍👦‍👦free for all Anyone is free to take on this issue and file a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: start-database.sh is marked optional kxzazz/create-t3-app
1 participant
@juliusmarminge