Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: themeToggler not working #1533

Closed
dreyfus92 opened this issue Aug 11, 2023 · 9 comments · Fixed by #1536
Closed

bug: themeToggler not working #1533

dreyfus92 opened this issue Aug 11, 2023 · 9 comments · Fixed by #1536
Labels
📌 area: site Relates to the create.t3.gg website 🐞 confirmed bug Something isn't working

Comments

@dreyfus92
Copy link

Provide environment information

I don't have any issue with the a local project.

Describe the bug

I was reading the docs and wanted to switch dark mode to light mode. I couldn't achieve it.
t3

Reproduction repo

https://github.com/t3-oss/create-t3-app

To reproduce

Just go to the docs website and try clicking the themeToggler.

Additional information

No response

@c-ehrlich
Copy link
Member

c-ehrlich commented Aug 13, 2023

update: the first deployment where it's broken is the one after merging this PR ea2a8c6#diff-34e8a4e8b2140f6ee0d228af30fddaa2583fe3f008869bf139c9b5fe8c649c61


update 2: it broke somewhere between commits 456d933 and 576cc26


thanks for the report. there seem to have been a bunch of regressions on the site. might all be related?

CleanShot 2023-08-13 at 09 41 57@2x

i'll try to bisect the vercel deployments tonight or tomorrow and find where it broke.

@c-ehrlich c-ehrlich added 🐞 confirmed bug Something isn't working 📌 area: site Relates to the create.t3.gg website and removed 🐞❔ unconfirmed bug labels Aug 13, 2023
@juliusmarminge
Copy link
Member

cc @FinnDore :)

@FinnDore
Copy link
Contributor

FinnDore commented Aug 13, 2023

oh, theres no way. wtf

we can promote the prev build to prod. ill have a look at this in a sec

@juliusmarminge
Copy link
Member

Promoted the previous one to prod so should work again.

@FinnDore
Copy link
Contributor

Kapture.2023-08-13.at.16.11.07.mp4

🤔 its working locally

@FinnDore
Copy link
Contributor

FinnDore commented Aug 13, 2023

however it does break once deployed, oh boy ( https://create-t3-app-www-eight.vercel.app/en/usage/next-auth )
image

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 94
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-www-eight.vercel.app/

@FinnDore
Copy link
Contributor

Noticing this in the console. but dont know enough about astro to know what the js bundle does
image

@FinnDore FinnDore mentioned this issue Aug 13, 2023
3 tasks
@FinnDore
Copy link
Contributor

opend a pr that fixes the issue, turns out some random astro dep got bumped which broke things. pinning deps are cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: site Relates to the create.t3.gg website 🐞 confirmed bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants