Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: language prompt short answer should both be ts #142

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

MWhite-22
Copy link
Member

Language prompt short answer should both be TS

  • I reviewed linter warnings + errors, resolved formatting, types and other issues related to my work
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

In a previous pr (#107) the short answer was changed to JavaScript. Both options should have a short options of TypeScript. The short value is shown after the question has been answered and we move on to the next question.

If we are telling the user that we are going to use TS instead, but show them JS was the selected answer, it can cause confusion. Let's keep messaging consistent, enhance UX, and show them that TS is the only way forward, no matter their selection.

@nexxeln nexxeln merged commit 5e4f80d into t3-oss:main Jul 7, 2022
@MWhite-22 MWhite-22 deleted the fix/language_prompt branch July 7, 2022 14:55
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants