-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CODEOWNERS for translation #1121
Comments
Sure, sign me in! |
I'm up for it |
You can label me, thanks for the invite. |
I'm In |
count me in |
I'm in |
👍 |
my mom will be proud of me :) |
sure |
me too! |
👍 |
Add me in for Spanish ! |
I can contribute for spanish! How's the progress on the spanish translation? |
So apparently I overpromised as it's not possible to make someone a code owner without also giving them full write access and access to repo secrets, see https://github.com/orgs/community/discussions/29982 I basically trust that everyone here is acting in good faith, but the goal is to have everyone now and future who contributes to a language also become a codeowner (or similar) for that language - contributors in most OSS come and go, and we want translations to stay strong. This would make "fix one typo, become codeowner, delete the repo" an obvious attack vector. Will go back to the drawing board and try to come up with a different solution. In the meantime it's back to tagging people manually 😅 If anyone knows how other projects handle this, let me know. |
Totally in, that said, you guys can mention me and I will stay reviewing and approving changes for the Portuguese translations, keep up the good work! |
Great! I'll try to find time to update the NO translations soon. |
Great!👍 |
@c-ehrlich Please replace this account (@lodisy) with @escwxyz, it would be merged. |
I would like to set up code owners for the translations. Being a code owner means you get a notification from GitHub when there is a PR with changes to the files of your language, so you can review them. If you want to be a code owner for your language, please reply below.
I've tagged people who have contributed in the past below. I just made this list by skimming through old PRs so I might have missed some people. If you've contributed in the past (writing or reviewing) and I forgot to tag you, or you notice that someone else who contributed to your language is not on the list, please let me know and I will tag them as well.
AR
@a4addel
@Sboonny
FR
@Defranos
@joachimjusth
NO
@estubmo
@josephayman
PO
@matibox
@Infiplaya
@PiotrekPKP
PT
@claudiofreitas
@minsk-dev
@Sn0wye
@victoriaquasar
RU:
@AmadeusTwi
@ronanru
@Yevhenii-Bakhmat
ZH-HANS:
@fernandoxu
@lodisy
The text was updated successfully, but these errors were encountered: