Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CODEOWNERS for translation #1121

Closed
c-ehrlich opened this issue Jan 25, 2023 · 18 comments · Fixed by #1158
Closed

feat: CODEOWNERS for translation #1121

c-ehrlich opened this issue Jan 25, 2023 · 18 comments · Fixed by #1158
Labels
📚 documentation Improvements or additions to documentation 🌟 enhancement New feature or request 🌎 translation Translation of documentation

Comments

@c-ehrlich
Copy link
Member

c-ehrlich commented Jan 25, 2023

I would like to set up code owners for the translations. Being a code owner means you get a notification from GitHub when there is a PR with changes to the files of your language, so you can review them. If you want to be a code owner for your language, please reply below.

I've tagged people who have contributed in the past below. I just made this list by skimming through old PRs so I might have missed some people. If you've contributed in the past (writing or reviewing) and I forgot to tag you, or you notice that someone else who contributed to your language is not on the list, please let me know and I will tag them as well.

AR
@a4addel
@Sboonny

FR
@Defranos
@joachimjusth

NO
@estubmo
@josephayman

PO
@matibox
@Infiplaya
@PiotrekPKP

PT
@claudiofreitas
@minsk-dev
@Sn0wye
@victoriaquasar

RU:
@AmadeusTwi
@ronanru
@Yevhenii-Bakhmat

ZH-HANS:
@fernandoxu
@lodisy

@c-ehrlich c-ehrlich added 🌟 enhancement New feature or request 📚 documentation Improvements or additions to documentation 🌎 translation Translation of documentation labels Jan 25, 2023
@AmadeusTwi
Copy link
Contributor

Sure, sign me in!

@matibox
Copy link
Contributor

matibox commented Jan 25, 2023

I'm up for it

@somecodingwitch
Copy link
Contributor

You can label me, thanks for the invite.

@a4addel
Copy link
Contributor

a4addel commented Jan 25, 2023

I'm In

@ghost
Copy link

ghost commented Jan 26, 2023

count me in

@PiotrekPKP
Copy link
Contributor

I'm in

@Sboonny
Copy link
Contributor

Sboonny commented Jan 26, 2023

👍

@JohnBakhmat
Copy link
Contributor

my mom will be proud of me :)

@marlalain
Copy link
Contributor

sure

@Infiplaya
Copy link

me too!

@josephayman
Copy link
Contributor

👍

@Nsttt
Copy link
Contributor

Nsttt commented Jan 29, 2023

Add me in for Spanish !

@chalop
Copy link
Contributor

chalop commented Jan 29, 2023

I can contribute for spanish! How's the progress on the spanish translation?

@c-ehrlich
Copy link
Member Author

c-ehrlich commented Jan 31, 2023

So apparently I overpromised as it's not possible to make someone a code owner without also giving them full write access and access to repo secrets, see https://github.com/orgs/community/discussions/29982

I basically trust that everyone here is acting in good faith, but the goal is to have everyone now and future who contributes to a language also become a codeowner (or similar) for that language - contributors in most OSS come and go, and we want translations to stay strong. This would make "fix one typo, become codeowner, delete the repo" an obvious attack vector.

Will go back to the drawing board and try to come up with a different solution. In the meantime it's back to tagging people manually 😅 If anyone knows how other projects handle this, let me know.

@Sn0wye
Copy link
Contributor

Sn0wye commented Feb 4, 2023

Totally in, that said, you guys can mention me and I will stay reviewing and approving changes for the Portuguese translations, keep up the good work!

@estubmo
Copy link
Contributor

estubmo commented Feb 8, 2023

Great! I'll try to find time to update the NO translations soon.

@fernandoxu
Copy link
Contributor

Great!👍

@ghost
Copy link

ghost commented Mar 25, 2023

@c-ehrlich Please replace this account (@lodisy) with @escwxyz, it would be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation 🌟 enhancement New feature or request 🌎 translation Translation of documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.