Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example with play-slick #141

Closed
djonmayer opened this issue Jul 6, 2015 · 10 comments
Closed

Example with play-slick #141

djonmayer opened this issue Jul 6, 2015 · 10 comments
Labels

Comments

@djonmayer
Copy link

Can you add please play2-auth-support to computer-database-sample of play-slick v1.0.0 (https://github.com/playframework/play-slick/tree/master/samples/computer-database)?

Regards
Djon

@gakuzzzz
Copy link
Member

gakuzzzz commented Jul 6, 2015

Only the information, I can't implement it.
What do for you do you how to authenticate, what authority the is needed where, unknown points too many...

@djonmayer
Copy link
Author

Can you combine your basic-sample with it?

@gakuzzzz
Copy link
Member

gakuzzzz commented Jul 6, 2015

I still not understand what do you want...

Do I send PullRequest to https://github.com/playframework/play-slick/ ?

@gakuzzzz
Copy link
Member

gakuzzzz commented Jul 6, 2015

When you fork computer-database-sample and try to combine play2-auth, If you will have some question, We will answer these question.

best,

@djonmayer
Copy link
Author

I've created a combination of both samples (https://github.com/djonmayer/play2-auth-slick)
But I get some errors during compilation. Can you check it out, please?

Regards

@gakuzzzz
Copy link
Member

gakuzzzz commented Jul 7, 2015

👍 nice try!

when you write what compilation error has occurred, we can answer quickly :)

It seems using Play2.4 and play2-auth 0.14.0
https://github.com/djonmayer/play2-auth-slick/blob/8132067f3d3404bb87f4642f40a55c99c1c320f1/project/plugins.sbt#L2
https://github.com/djonmayer/play2-auth-slick/blob/8132067f3d3404bb87f4642f40a55c99c1c320f1/build.sbt#L16

However AuthConfigImpl seems using old style for Play2.3 and play2-auth 0.13.0

Would you see currents README
https://github.com/t2v/play2-auth#usage

@djonmayer
Copy link
Author

Thank you for your hint.
In your case has a function Account.findById() or Account.findByEmail() Option[Account] as return value. In my case it is Future[Option[Account]], so I get an error by mapping of loginForm / dataForm.

@gakuzzzz
Copy link
Member

yes, you should change dataForm to handle Future[Option[Account]]

Play2 Form API document is here. https://www.playframework.com/documentation/2.4.2/ScalaForms

@marius-carp
Copy link

Hi @djonmayer,
I manged to fix some of those errors.
https://github.com/marius-carp/play2-auth-slick

@gakuzzzz
Copy link
Member

gakuzzzz commented Oct 6, 2015

thanks for your support comment, @marius-carp.

I close this issue. if there are some question, plese come gitter https://gitter.im/t2v/play2-auth :)

@gakuzzzz gakuzzzz closed this as completed Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants