-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forwarding refs for a polymorphic React component #2356
Comments
Thanks for the detailed issue! PR fixing this for everyone would be very welcomed :) Previous attempts to fix this have been too slow, unfortunately. |
Just FYI, the PR addressing this should attach Personally, I think it's a footgun, and its every use case could be instead built with Radix UI's |
Is your feature request related to a problem? Please describe.
At the moment, if I would try to use
Box
with aas='svg' viewBox='0 0 24 24'
property, typescript will complain about the fact thatviewBox
is not a Box property, but that shouldn't be the case, as it is a property ofsvg
. Plus, they should also allow passing and accepting the correct ref property.The same goes for other components, especially Flex and Text.
I did my own local override implementation of the types taking inspiration from this article, but would be great if this would come directly from theme-ui.
Thank you
The text was updated successfully, but these errors were encountered: