From 9c192940e02fe264c57f842f92d35cf94e043d4d Mon Sep 17 00:00:00 2001 From: reuk Date: Mon, 3 Jun 2024 12:04:24 +0100 Subject: [PATCH] VST3 Client: Avoid returning kResultNotImplemented from setComponentState The base implementation of this function does nothing, and returns 'not implemented'. It is more correct to return 'ok', to indicate that setting the component state succeeded. --- .../juce_audio_plugin_client_VST3.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/juce_audio_plugin_client/juce_audio_plugin_client_VST3.cpp b/modules/juce_audio_plugin_client/juce_audio_plugin_client_VST3.cpp index 48c86047c4f2..b71252f9b030 100644 --- a/modules/juce_audio_plugin_client/juce_audio_plugin_client_VST3.cpp +++ b/modules/juce_audio_plugin_client/juce_audio_plugin_client_VST3.cpp @@ -1040,7 +1040,7 @@ class JuceVST3EditController final : public Vst::EditController, #endif //============================================================================== - tresult PLUGIN_API setComponentState (IBStream* stream) override + tresult PLUGIN_API setComponentState (IBStream*) override { // As an IEditController member, the host should only call this from the message thread. assertHostMessageThread(); @@ -1065,7 +1065,7 @@ class JuceVST3EditController final : public Vst::EditController, if (auto* handler = getComponentHandler()) handler->restartComponent (Vst::kParamValuesChanged); - return Vst::EditController::setComponentState (stream); + return kResultOk; } void setAudioProcessor (JuceAudioProcessor* audioProc)