[Snyk] Security upgrade ethers from 5.7.2 to 6.0.0 #3022

trajan0x · 2024-08-15T04:22:04Z

Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

packages/synapse-interface/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️

Warning

Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

	Issue	Score
	Improper Verification of Cryptographic Signature SNYK-JS-ELLIPTIC-7577916	848
	Improper Verification of Cryptographic Signature SNYK-JS-ELLIPTIC-7577917	848
	Improper Verification of Cryptographic Signature SNYK-JS-ELLIPTIC-7577918	848

Important

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-7577916 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-7577917 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-7577918

cloudflare-workers-and-pages · 2024-08-15T04:22:07Z

Deploying sanguine-fe with Cloudflare Pages

Latest commit:	`4f1b1bd`
Status:	🚫 Build failed.

View logs

coderabbitai · 2024-08-15T04:22:09Z

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)

WIP
DO NOT MERGE

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

greptile-apps

PR Summary

This PR upgrades the 'ethers' package from version 5.7.2 to 6.0.0 in the synapse-interface package.json file to address critical security vulnerabilities.

Addresses three critical vulnerabilities (SNYK-JS-ELLIPTIC-7577916, SNYK-JS-ELLIPTIC-7577917, SNYK-JS-ELLIPTIC-7577918) related to improper verification of cryptographic signatures
Major version upgrade from ethers 5.x to 6.0.0 may introduce breaking changes in the codebase
Upgrade fixes vulnerabilities with a high priority score of 848 out of 1000
Failed to update yarn.lock file, manual update required before merging
Consider thorough testing of ethers-dependent functionality due to potential breaking changes in the new version

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

codecov · 2024-08-15T04:27:29Z

Bundle Report

Bundle size has no change ✅

Bundle name	Size	Change
sdk-router-@synapsecns/sdk-router-cjs	117.19kB	0 bytes
synapse-interface-edge-server-array-push	83 bytes	0 bytes
synapse-interface-client-array-push	7.46MB	0 bytes
sdk-router-@synapsecns/sdk-router-esm	254.83kB	0 bytes
synapse-interface-server-cjs	1.53MB	0 bytes

codecov · 2024-08-15T04:28:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.71326%. Comparing base (77f5863) to head (4f1b1bd).
Report is 217 commits behind head on master.

Additional details and impacted files

@@              Coverage Diff              @@
##              master       #3022   +/-   ##
=============================================
  Coverage   20.71326%   20.71326%           
=============================================
  Files            490         490           
  Lines          42509       42509           
  Branches          82          82           
=============================================
  Hits            8805        8805           
  Misses         32769       32769           
  Partials         935         935

Flag	Coverage Δ
packages	`90.55118% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-08-30T02:31:55Z

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions · 2024-09-14T02:31:35Z

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions · 2024-09-29T02:44:18Z

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

fix: packages/synapse-interface/package.json to reduce vulnerabilities

4f1b1bd

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-7577916 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-7577917 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-7577918

trajan0x requested review from bigboydiamonds, abtestingalpha and aureliusbtc as code owners August 15, 2024 04:22

github-actions bot added M-synapse-interface size/xs labels Aug 15, 2024

greptile-apps bot reviewed Aug 15, 2024

View reviewed changes

github-actions bot added the needs-yarn-install label Aug 15, 2024

github-actions bot added Stale and removed Stale labels Aug 30, 2024

github-actions bot added Stale and removed Stale labels Sep 14, 2024

github-actions bot added Stale and removed Stale labels Sep 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Snyk] Security upgrade ethers from 5.7.2 to 6.0.0 #3022

[Snyk] Security upgrade ethers from 5.7.2 to 6.0.0 #3022

trajan0x commented Aug 15, 2024

cloudflare-workers-and-pages bot commented Aug 15, 2024 •

edited

Loading

coderabbitai bot commented Aug 15, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

greptile-apps bot left a comment

codecov bot commented Aug 15, 2024

codecov bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 30, 2024

github-actions bot commented Sep 14, 2024

github-actions bot commented Sep 29, 2024

[Snyk] Security upgrade ethers from 5.7.2 to 6.0.0 #3022

Are you sure you want to change the base?

[Snyk] Security upgrade ethers from 5.7.2 to 6.0.0 #3022

Conversation

trajan0x commented Aug 15, 2024

Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

Note for zero-installs users

Vulnerabilities that will be fixed with an upgrade:

cloudflare-workers-and-pages bot commented Aug 15, 2024 • edited Loading

Deploying sanguine-fe with Cloudflare Pages

coderabbitai bot commented Aug 15, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

codecov bot commented Aug 15, 2024

Bundle Report

codecov bot commented Aug 15, 2024 • edited Loading

Codecov Report

github-actions bot commented Aug 30, 2024

github-actions bot commented Sep 14, 2024

github-actions bot commented Sep 29, 2024

cloudflare-workers-and-pages bot commented Aug 15, 2024 •

edited

Loading

coderabbitai bot commented Aug 15, 2024 •

edited

Loading

codecov bot commented Aug 15, 2024 •

edited

Loading