Skip to content

Latest commit

 

History

History
96 lines (60 loc) · 6.21 KB

CONTRIBUTING.md

File metadata and controls

96 lines (60 loc) · 6.21 KB
Raw

Welcome to the Swift Community!

Contributions to vscode-swift are welcomed and encouraged! Please see the Contributing to Swift guide and check out the structure of the community.

To be a truly great community, Swift needs to welcome developers from all walks of life, with different backgrounds, and with a wide range of experience. A diverse and friendly community will have more great ideas, more unique perspectives, and produce more great code. We will work diligently to make the Swift community welcoming to everyone.

To give clarity of what is expected of our members, Swift has adopted the code of conduct defined by the Contributor Covenant. This document is used across many open source communities, and we think it articulates our values well. For more, see the Code of Conduct.

Contributing to /vscode-swift

Development

To begin development on the VS Code extension for Swift you will need to install Node.js. We use nvm the Node version manager to install Node.js. To install or update nvm you should run their install script

curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash

More details on nvm installation can be found in the README from its GitHub repository.

Once you have installed nvm, you can clone and configure the repository.

git clone https://github.com/swift-server/vscode-swift.git && cd vscode-swift

# Install the correct version of Node.JS for developing the extension
nvm install

# Installs all the dependencies the extension requires
npm install

When you first open the project in VS Code you will be recommended to also install ESLint, Prettier - Code formatter and esbuild Problem Matchers. Please do so. ESLint, Prettier - Code formatter is used to ensure a consistent style and we expect everyone who contributes to follow this style as well. esbuild Problem Matchers provides proper error output from building the project.

To run your version of the Swift extension while in VS Code, press F5. This will open up another instance of VS Code with it running. You can use the original version of VS Code to debug it.

Installing a pre-released version

If you'd like to try out a change during your day to day work that has not yet been released to the VS Code Marketplace you can build and install your own .vsix package from this repository.

Building

If you haven't already, follow the instructions in Development to clone the repository and install its dependencies. Now we can generate the .vsix package:

npm run dev-package

This builds a file that looks like swift-lang-[version]-dev.vsix. Now install the extension with:

code --install-extension swift-lang-[version]-dev.vsix

Alternatively you can install the extension from the Extensions panel by clicking the ... button at the top of the panel and choosing Install from VSIX....

If you'd like to return to using the released version of the extension you can uninstall then reinstall Swift for VS Code from the Extensions panel.

Submitting a bug or issue

Please ensure to include the following in your bug report:

  • A concise description of the issue, what happened and what you expected.
  • Simple reproduction steps
  • Version of the extension you are using
  • Contextual information (Platform, Swift version etc)

Submitting a Pull Request

Please ensure to include the following in your Pull Request (PR):

  • A description of what you are trying to do. What the PR provides to the library, additional functionality, fixing a bug etc
  • A description of the code changes
  • Documentation on how these changes are being tested
  • Additional tests to show your code working and to ensure future changes don't break your code.

Please keep your PRs to a minimal number of changes. If a PR is large, try to split it up into smaller PRs. Don't move code around unnecessarily as it makes comparing old with new very hard. If you have plans for a large change please talk to the maintainers of the project beforehand. There is a #vscode-swift channel on the Swift Server Slack. You can join here.

Testing

Where possible any new feature should have tests that go along with it, to ensure it works and will continue to work in the future. When a PR is submitted one of the prerequisites for it to be merged is that all tests pass.

For information on levels of testing done in this extension, see the test strategy.

To get started running tests first import the testing-debug.code-profile VS Code profile used by the tests. Run the > Profiles: Import Profile... command then Select File and pick ./.vscode/testing-debug.code-profile.

Now you can run tests locally using either of the following methods:

  • From VS Code, by selecting "Extension Tests" in the Run and Debug activity.
  • Using npm run test from the command line (when VS Code is not running, or you'll get an error)

sourcekit-lsp

The VS Code extension for Swift relies on Apple's sourcekit-lsp for syntax highlighting, enumerating tests, and more. If you want to test the extension with a different version of the sourcekit-lsp you can add a swift.sourcekit-lsp.serverPath entry in your local settings.json to point to your sourcekit-lsp binary. The setting is no longer visible in the UI because it has been deprecated.

Warning

If your sourcekit-lsp version does not match your toolchain you may experience unexpected behaviour.

Legal

By submitting a pull request, you represent that you have the right to license your contribution to the community, and agree by submitting the patch that your contributions are licensed under the Apache 2.0 license (see LICENSE).