Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript][Node] support for overriding HTTP request headers #9036

Merged
merged 1 commit into from
Feb 9, 2019
Merged

[TypeScript][Node] support for overriding HTTP request headers #9036

merged 1 commit into from
Feb 9, 2019

Conversation

silasbw
Copy link
Contributor

@silasbw silasbw commented Jan 7, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This approach is inspired by the typescript-fetch implementation.

Fixes #9035

@silasbw
Copy link
Contributor Author

silasbw commented Jan 7, 2019

cc @CodeNinjai and @wing328

I wanted to attach an example implementation that satisfies #9035. I realize this PR could be extended to provide more consistency with typescript-fetch by, for example, implementing qs overrides. I'm happy to help do that, or try a different approach for setting content-type.

@wing328
Copy link
Contributor

wing328 commented Jan 16, 2019

@silasbw Thanks for tagging me but I'm no longer involved in this project. I hope others will be able to help you out. Good luck.

@silasbw
Copy link
Contributor Author

silasbw commented Jan 16, 2019

@CodeNinjai are the right person to provide feedback on this? or could you tag the right person?

@silasbw
Copy link
Contributor Author

silasbw commented Jan 16, 2019

fwiw, I added a similar change to openapi-generator: OpenAPITools/openapi-generator#1868

This approach is inspired by the typescript-fetch implementation.

Fixes #9035
@silasbw
Copy link
Contributor Author

silasbw commented Feb 2, 2019

@frantuma, I saw you had some commit activity recently :) any chance you can point me at the maintainers for this code so I can work with them on this change?

@HugoMario HugoMario merged commit b5150ef into swagger-api:master Feb 9, 2019
@HugoMario
Copy link
Contributor

hello @silasbw thanks a lot for this PR. i think i'm going to take a time to port this to 3.0.x version. BTW any time you need help with a PR just let me know.

@silasbw
Copy link
Contributor Author

silasbw commented Feb 9, 2019

Sounds good, thanks @HugoMario 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants