Qt5cpp plug memleaks #7695
Merged
Qt5cpp plug memleaks #7695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually the original solution is incomplete, because "innerType" maps to a single C++ type. Have a look at Qt's builtin QJsonObject::fromVariantMap.
…tch-1' into qt5cpp_plug_memleaks # Conflicts: # modules/swagger-codegen/src/main/resources/qt5cpp/HttpRequest.cpp.mustache # modules/swagger-codegen/src/main/resources/qt5cpp/api-body.mustache # modules/swagger-codegen/src/main/resources/qt5cpp/helpers-body.mustache # modules/swagger-codegen/src/main/resources/qt5cpp/helpers-header.mustache
|
Gave it a short review. -> Looking good in general, only some tests seem to fail. Prbly those need a little adjustment… |
|
Tests
|
|
Next set of updates planned would be to
|
|
@wing328 Why does the circleci failed? I tested the petstore samples with the IDE and they passed. |
|
@etherealjoy probably due to maven repo throttling the connection to download dependencies. I've restarted the job and the result is good. |
|
Hi @fvarose @stkrwork @ravinikam |
stkrwork
approved these changes
Mar 5, 2018
|
@etherealjoy as always, thanks for your work 👍 @stkrwork thanks for reviewing the change. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Remove some Memory Leaks in the Model Factory and API
cc @fvarose @stkrwork @ravinikam
Plug some of the Qt Memory leaks.
Based on #7194 by @antis81