php syntax error #116

[ifrolikov]

Hey! I create new issue, because previous issue was closed.
There are {{#hasMore}} attribute was still in some places:

• src/main/resources/v2/php/README.mustache
• src/main/resources/v2/php/api.mustache
• src/main/resources/v2/php/api_doc.mustache
• src/main/resources/v2/php/model_generic.mustache

Thank!

[ifrolikov]

ifrolikov/swagger-codegen-generators@352b1ca

my fork

[ifrolikov]

Ping :)

[HugoMario]

Hey @ifrolikov thanks for your ping, i had missed it this one.

i'm going to check it.

[HugoMario]

@ifrolikov can you create the PR from your fork so we can merge your changes here?

[ifrolikov]

Hey @HugoMario , #123, I create PR :)

[ifrolikov]

Hey, @HugoMario! I'm sorry, that I write really often, but it is important to me. Swagger codegen get an old snapshot of swagger-codegen-generators while building:

Is this problem of build, which you told me?

[HugoMario]

It's ok @ifrolikov, feel free to ping any time you need. it should look for latest, let me check this and let you know.

[HugoMario]

@ifrolikov what command are you using for building, would you try with:

mvn clean install -U

in case you're using a different one?

[ifrolikov]

I'm build image from dockerfile:
.

I'm look repo https://oss.sonatype.org/content/repositories/snapshots/io/swagger/swagger-codegen-generators/1.0.0-SNAPSHOT/ and latest version of snapshot is 2018-07-20. Should not a new version of the snapshot be created after my PR merged? (#126)

[HugoMario]

I think this is related to the circular dependency issue we have in swagger-codegen repo for 3.0.0.

We need to trigger a build on swagger-codegen in order to fix this. This circular dependency issue should be fixed with project refactoring tasks that we're working right now.

I'll try to manually fix this temporary and let you know.

[pavog]

Hey I think you can close this issue now, since #123 and #124 have been merged.

[ifrolikov]

I forgot about it, thanks!