-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving a text with an inside title element fails #1304
Comments
If your text elements are not multiline, you can use the following workaround:
This will prevent rebuilding (which seems to be only necessary for multiline support in text elements) and therefore prevent the NP. |
I attempted to fix it here: 8fa0873 Please test and report back if it works for you. |
@Fuzzyma Thank you for your work. It works as intended now. When can we get a new build in order to profit from these fixes? |
I am sorry, I somehow forgot to publish all the fixes I made. I just released it: |
If you have a text element with a title element inside, moving that text element will fail with:
Uncaught TypeError: Cannot read properties of undefined (reading 'newLined') at Dom.<anonymous> (Text.js:56:22) at Text.each (Dom.js:84:13) at Text.rebuild (Text.js:50:12) at Text.attr (attr.js:79:12) at Text.ax (textable.js:68:15)
DOM:
<text x="200" y="294">row10<title>row10</title></text>
Reason: .ax() is leading to a rebuild of the text element. Rebuilding the text element will also go through all children. When reaching the title child element, there is no this.dom.
The text was updated successfully, but these errors were encountered: