-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React-like efficient hydration #4975
Labels
Comments
This was referenced Jun 11, 2020
Closed
Closed
There was another bug, so the performance improvement was reverted. I'm going to leave this closed as a duplicate of #4308 and we can track getting the performance improvement reimplemented in that issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are a number of open requests for more efficient hydration. Most notably #4308, but also #4297, #2152, #4444, and others. However, they all seem to still be doing far more work than I think is necessary.
The React
hydrate
docs say:This is what I would intuitively think hydration should do. I.e. attach event listeners and nothing more. This would be much more efficient at runtime as well as resulting in smaller bundles.
I'm not sure if there's a reason why SvelteJS today does a diff operation that compares the initial DOM to expected DOM when hydrating. It seems unnecessary in the majority of cases. Though I could see it being useful in development and testing. This would be a breaking change, but maybe could be added with an option and the old hydration method could be deprecated and eventually removed.
The text was updated successfully, but these errors were encountered: