Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename __fetch_polyfill to installFetch #4098

Closed
Rich-Harris opened this issue Feb 23, 2022 · 2 comments · Fixed by #4111
Closed

rename __fetch_polyfill to installFetch #4098

Rich-Harris opened this issue Feb 23, 2022 · 2 comments · Fixed by #4111
Milestone

Comments

@Rich-Harris
Copy link
Member

Describe the problem

I have no idea why it's called that.

Describe the proposed solution

import { installFetch } from '@sveltejs/kit/install-fetch';

Alternatives considered

No response

Importance

nice to have

Additional Information

No response

@Conduitry
Copy link
Member

I think that name came from before we were bundling things the same way we are now, and we wanted a name that was unlikely to collide with user code.

@benmccann benmccann added this to the 1.0 milestone Feb 23, 2022
@Rich-Harris
Copy link
Member Author

Also, I don't think there's a good reason for that module to re-export fetch, Headers, Request and Response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants