Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrub references to Trelis #736

Merged
merged 6 commits into from
May 25, 2021
Merged

Scrub references to Trelis #736

merged 6 commits into from
May 25, 2021

Conversation

gonuke
Copy link
Member

@gonuke gonuke commented Apr 1, 2021

Description

At the prompting of our Coreform partners, I am attempting to remove all references to Trelis from our docs

Motivation and Context

Trelis is no longer available as a product and we should refer to Coreform Cubit instead.

Changes

Change all documentation to refer to Coreform Cubit

@gonuke gonuke changed the title First pass to scrub reference to Trelis Scrub references to Trelis Apr 1, 2021
Copy link
Contributor

@ngranda ngranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have just one question about the Cubit folder in the OS/X plugin install.

3. Run the install script: ``./install.sh``.

OS/X install
~~~~~~~~~~~~

Obtain the OS/X plugin from the link above. These instructions assume that you
have installed Trelis in ``/Applications/Trelis-16.0``. If you installed it
have installed Cubit in ``/Applications/Trelis-16.0``. If you installed it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Trelis-16.0 still the folder name in OS/X?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question - I don't know - maybe @bam241 can help answer this

doc/install/plugin.rst Outdated Show resolved Hide resolved
Comment on lines 31 to 34
``/Applications/Coreform-Cubit-2020.2.app/Contents/MacOS``.
2. Unpack the tarball in ``/Applications/Coreform-Cubit-2020.2.app/Contents/MacOS/plugins``.
3. Change directory to
``/Applications/Trelis-16.0/Contents/MacOS/plugins/dagmc``.
``/Applications/Coreform-Cubit-2020.2.app/Contents/MacOS/plugins/dagmc``.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these paths also correct, then, @bam241 (I just updated them based on the above fix)?

3. Change directory to
``/Applications/Trelis-16.0/Contents/MacOS/plugins/dagmc``.
``/Applications/Coreform-Cubit-2020.2.app/Contents/MacOS/plugins/dagmc``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
``/Applications/Coreform-Cubit-2020.2.app/Contents/MacOS/plugins/dagmc``.
`` /Applications/Coreform-Cubit-2020.2.app/Contents``.

1. Unpack the tarball in ``/opt/Trelis-16.0/bin/plugins``.
2. Change directory to ``/opt/Trelis-16.0/bin/plugins/dagmc``.
3. Run the install script: ``./install.sh``.
- Unpack the tarball in the Cubit installation folder (``/opt/Coreform-Cubit-2020.2`` by default).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bam241, do users no longer need to run an install.sh script to install?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not anymore.
the new plugin is simpler to install :)

@ngranda
Copy link
Contributor

ngranda commented Apr 21, 2021

Is this ready to merge? There is one test that is failing but it doesn't seem to be related to this PR. Is it okay to merge or try rerunning the tests? ...

@gonuke
Copy link
Member Author

gonuke commented Apr 22, 2021

The test failures are presumed to be an upstream flaw in MOAB, so we should probably wait for that to be fixed...

@bam241
Copy link
Member

bam241 commented May 25, 2021

looking good, will ignore CI fails as this is housekeeping changes only and housekeeping passed.

Merging!
thx @gonuke!!!

@bam241 bam241 merged commit a077ae7 into svalinn:develop May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants