-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DagMC class from MOAB namespace #871
Labels
Comments
Definitely worth looking at. This is most likely a legacy of the origins of DAGMC, but may provide some convenience with not having to reference things explicitly through the MOAB namespace, e.g. error values, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The DagMC class is part of the MOAB namespace, but I don't see any reason for it to be. In fact, this is potentially confusing as it seems to act as an extension to the MOAB library (which was the intent some time ago I believe).
I don't think removing the MOAB namespace will have any significant downstream effects outside of DAGMC.
Open to others' thoughts on this!
The text was updated successfully, but these errors were encountered: