Fix compiler warning

[slashmili]

Elixir compiler complains about this line :

warning: an expression is always required on the right side of ->. Please provide a value after ->
  lib/hulaaki/client.ex:179

[suvash]

Hi there. Thanks for this patch. Can you perhaps, add a test for this change ?

[slashmili]

Done

…

On Thu 18. Jan 2018 at 06:41, Suvash Thapaliya ***@***.***> wrote: Hi there. Thanks for this patch. Can you perhaps, add a test for this change ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#34 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjwJGw6sE8ijTbX4duG6kWdQSbu8C1mks5tLtmjgaJpZM4Raeut> .

[slashmili]

On the second thought, should we replace the case with ‘with’? Then it does not need the :noop in code

…

On Thu 18. Jan 2018 at 16:55, Milad Rastian ***@***.***> wrote: Done On Thu 18. Jan 2018 at 06:41, Suvash Thapaliya ***@***.***> wrote: > Hi there. Thanks for this patch. Can you perhaps, add a test for this > change ? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#34 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAjwJGw6sE8ijTbX4duG6kWdQSbu8C1mks5tLtmjgaJpZM4Raeut> > . >

[suvash]

I'm not so sure about the :noop strategy here. I'd rather raise an NotSupported exception, so it blows up. Let me think about this a bit.

[slashmili]

@suvash the reason I pushed this PR is because elixir 1.6 gives warning for this line.

I recommend to merge this and think about this later since there is nothing new added to the code . Specially that it has test case now!

BTW if I want to raise exception on that place, I would bump the MAJOR version to avoid breaking users application that are using this library. Unless you know this branch of code never gets executed.

[suvash]

Fair enough. I'll have that done in the next major release.

[suvash]

I just realised that this was a bad test (it's def. not setting qos != 1 here). My bad that I let this through, will get rid of this in a future commit.