Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo shortcut missing #324

Closed
LucyEgan opened this issue Jun 5, 2024 · 7 comments
Closed

Redo shortcut missing #324

LucyEgan opened this issue Jun 5, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@LucyEgan
Copy link

LucyEgan commented Jun 5, 2024

Describe the bug
Currently undo via Ctrl + Z and redo via Ctrl + Y are available, but redo via Ctrl + Shift + Z is missing

To Reproduce
Steps to reproduce the behaviour:

  1. Go to 'query editor'
  2. Press 1 (1), [BACKSPACE], 2 (2), [BACKSPACE], 3 (3)
  3. Press Ctrl + Z (), Ctrl + Z (1)
  4. Press Ctrl + Shift + Z (Should be 2)

Expected behaviour
Pressing Ctrl + Shift + Z should be the same as Ctrl + Y

Environment:
Platform: Desktop
OS: Windows_NT
Architecture: x86_64
WebView: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537.36 Edg/125.0.0.0
Version: 2.0.0
Flags: featureFlags: true, models_view: true, apidocs_view: true, themes: true, newsfeed: true

@LucyEgan LucyEgan added the bug Something isn't working label Jun 5, 2024
@macjuul
Copy link
Contributor

macjuul commented Jun 28, 2024

This should be working correctly in the latest release

@macjuul macjuul closed this as completed Jun 28, 2024
@LucyEgan
Copy link
Author

LucyEgan commented Jun 28, 2024

@macjuul Is "latest release" referring to a upcoming version as this is still the case in 2.1.2?

Running version 2.1.2 shortcut Ctrl + Shift + Z does nothing.

Platform: Desktop
OS: windows
Architecture: x86_64
WebView: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36 Edg/126.0.0.0
Version: 2.1.2
Flags: feature_flags: true, models_view: true, apidocs_view: true, themes: true, newsfeed: true, database_version_check: false, highlight_tool: true, surreal_compat: v2, changelog: auto

@macjuul
Copy link
Contributor

macjuul commented Jun 28, 2024

Strange, it's working fine for me on 2.1.2 on both the desktop app (MacOS) and web

@macjuul macjuul reopened this Jun 28, 2024
@LucyEgan
Copy link
Author

I'll have a check on osx web and windows web when I get a moment.
Is the shortcut bound to meta + shift + z? Cus that would be correct for osx and not Windows or are both bound?

@Sandros94
Copy link

Strange, it's working fine for me on 2.1.2 on both the desktop app (MacOS) and web

Not on windows (or at least for me), both desktop and web

@LucyEgan
Copy link
Author

Can confirm it worked fine on OSX but not windows

@macjuul
Copy link
Contributor

macjuul commented Jun 29, 2024

Thanks for checking! I have implemented a fix which will be included in the next release

@macjuul macjuul closed this as completed Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants