-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let users pass through 'slots' for custom icons #1
Comments
Great idea. I should also add a logic here to support close icon as well. As you can see its bit clever here 😀 Maybe something like this. Default can be empty to use the current one. <MenuIcons>
<OpenIcon><svg/></OpenIcon>
<CloseIcon><svg/></CloseIcon>
</MenuIcons> |
Aye that would be alot better for the |
Done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey paji, I really like what you have done with this set of components,
But I was thinking it might be a bit better for the
DX
if we could pass in as a slot another Icon that they would like to use or even leverageastro-icon
in the background to then let users just pass in via prop the name of the icon they want to consume.This is a great component, I really do like how you have composed this.
astro-navbar/src/components/MenuIcon.astro
Lines 9 to 28 in dd75d2d
The text was updated successfully, but these errors were encountered: