Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up refresh API calls by not needing encryption / decryption #9

Open
rishabhpoddar opened this issue Sep 11, 2020 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@rishabhpoddar
Copy link
Member

rishabhpoddar commented Sep 11, 2020

While this would speed things up, we must analyse what effect each stolen item can have. CSRF protection does not count since that validation is stateless. We must assume that the attacker can create their own refresh token given the session handle. In case they do that, it should yield an unauthorised error.

A few questions to think about:

  • what if the attacker keeps everything the same, except changes the userId in the token?
  • Would it be easy for the attacker to trigger a token theft detection error?

If that is guaranteed, then we can remove the need for encryption, else we can at least use a method that's less time consuming.

@rishabhpoddar rishabhpoddar added the enhancement New feature or request label Sep 16, 2020
@rishabhpoddar rishabhpoddar self-assigned this Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant