Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any config to go through docker without having to explicitly define them the entrypoint.sh file #76

Open
rishabhpoddar opened this issue Oct 14, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@rishabhpoddar
Copy link
Member

rishabhpoddar commented Oct 14, 2020

馃殌 Feature

This is in accordance to #74.

In the way we are architecting recipes, there can be a random set of configuration values that may be needed by the recipe. This requires that env variables passed to a docker container can handle any such variables and put them in the config.yaml file.

If this is not possible, we will have to change the core to read config values from:

  • The OS env; and then
  • The config.yaml file

Since docker env are flat, we must also make sure that the config values do not clash across recipes. This can be done by each config value for a recipe is prefixed with the rId. For example, a recipe called emailpassword will have all its config values like email_password_*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants