Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base64 encode for metadata in headers #519

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Jul 11, 2024

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

When passing metadata via the x-metadata header, it will now need to be a base64 encoded json string.

Copy link

Pull Request Test Coverage Report for Build 9889931439

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 79.577%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/uploader.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 9859135697: 0.01%
Covered Lines: 13167
Relevant Lines: 16396

💛 - Coveralls

@fenos fenos force-pushed the fix/base64-on-metadata-headers branch from 01402bd to 1161559 Compare July 11, 2024 11:37
@fenos fenos force-pushed the fix/base64-on-metadata-headers branch from 1161559 to 2af73d0 Compare July 11, 2024 11:42
@fenos fenos merged commit f6d2fbc into master Jul 11, 2024
1 check passed
@fenos fenos deleted the fix/base64-on-metadata-headers branch July 11, 2024 12:30
Copy link

🎉 This PR is included in version 1.7.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants