Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 830 #461

Merged
merged 10 commits into from
Jul 9, 2024
Merged

Fix 830 #461

merged 10 commits into from
Jul 9, 2024

Conversation

juancarlospaco
Copy link
Contributor

@juancarlospaco juancarlospaco commented Jun 24, 2024

What kind of change does this PR introduce?

The user who reported it already closed it (by using a workaround), but the fix still applies and improves the code.

Copy link
Contributor

sourcery-ai bot commented Jun 24, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@juancarlospaco juancarlospaco marked this pull request as draft June 24, 2024 21:24
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (b858685) to head (f69bfad).
Report is 59 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
+ Coverage   95.72%   95.94%   +0.22%     
==========================================
  Files          28       28              
  Lines        1639     1753     +114     
==========================================
+ Hits         1569     1682     +113     
- Misses         70       71       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juancarlospaco juancarlospaco marked this pull request as ready for review June 26, 2024 19:44
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@silentworks
Copy link
Contributor

Please add some tests showing this fixing the same scenario from the issue you linked to.

@juancarlospaco juancarlospaco marked this pull request as draft July 4, 2024 18:57
@juancarlospaco juancarlospaco marked this pull request as ready for review July 5, 2024 10:50
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@mansueli mansueli merged commit ea791f4 into supabase-community:master Jul 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Percentage wildcard in like filter throws postgrest.exceptions.APIError
3 participants