Refactor create_client functions to call constructor directly #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
===========================================
+ Coverage 43.97% 64.44% +20.46%
===========================================
Files 13 13
Lines 332 315 -17
===========================================
+ Hits 146 203 +57
+ Misses 186 112 -74 ☔ View full report in Codecov by Sentry. |
silentworks
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor changes discussed in #798
What is the current behavior?
Right now,
acreate_clientis a re-import of the_async.client.create_clientfunction. This function, in its body, calls theAsyncClient.createasynchronous class method (see source code). This method itself callsAsyncClient.__init__(see source code). This chain of function calls, passing the same arguments with the same names three times until it reaches the destination constructor, seems to introduce some unnecessary abstractions.What is the new behavior?
Both
_async.client.create_clientand_sync.client.create_clientdirectly call the corresponding class's constructors (AsyncClient.__init__andSyncClient.__init__).Meta
Closes #798