Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce code consistency via pre-commit #26

Closed
olirice opened this issue May 19, 2021 · 1 comment · Fixed by #28
Closed

Enforce code consistency via pre-commit #26

olirice opened this issue May 19, 2021 · 1 comment · Fixed by #28
Labels
enhancement New feature or request

Comments

@olirice
Copy link
Contributor

olirice commented May 19, 2021

Feature request

Is there any interest in hooking up pre-commit with the usual battery hooks for python libraries e.g. black, isort, autoflake, and mypy, to enforce code consistency/standards?

If so, I'm happy to open a PR
@olirice olirice added the enhancement New feature or request label May 19, 2021
@olirice olirice mentioned this issue May 22, 2021
Merged
@J0
Copy link
Collaborator

J0 commented May 22, 2021 •
edited
Loading

Yeah! A pre-commit hook with isort, black autoflake , and mypy would be really helpful in enforcing code consistency. We should probably add a check in CI as well

Please feel free to go for it. Thank you for suggesting this :)

@olirice olirice mentioned this issue May 22, 2021
Merged
@J0 J0 closed this as completed in #28 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pre-commit hooks enforcing a standard style olirice/supabase-py
2 participants
@J0 @olirice