Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvg port to ux-dx #7

Open
dudochkin-victor opened this issue Jul 29, 2021 · 4 comments
Open

nvg port to ux-dx #7

dudochkin-victor opened this issue Jul 29, 2021 · 4 comments

Comments

@dudochkin-victor
Copy link

I just ported nvg from glow to ux-dx. And I would like to put it in ux-dx.
I would like to know your opinion on this matter. I hope there will be no problems with licensing.
I have my own vision of a general purpose 3D library, so I developed ux-dx, which is OpenGL ES 2.0 / 3.0 + binding at the moment.
I will also be glad if you join the ux-dx project.

@sunli829
Copy link
Owner

sunli829 commented Aug 1, 2021

I just ported nvg from glow to ux-dx. And I would like to put it in ux-dx.
I would like to know your opinion on this matter. I hope there will be no problems with licensing.
I have my own vision of a general purpose 3D library, so I developed ux-dx, which is OpenGL ES 2.0 / 3.0 + binding at the moment.
I will also be glad if you join the ux-dx project.

Feel free to modify it without any problems. 🙂

@tasogare3710
Copy link

tasogare3710 commented Aug 4, 2021

@dudochkin-victor It's a little confusing, but nvg is under the MIT license.

license = "MIT"

I have my own vision of a general purpose 3D library, so I developed ux-dx, which is OpenGL ES 2.0 / 3.0 + binding at the moment.

I'm forking nvg, and AFAIR, adding the gles backend to nvg should have only required changing the linking library from opengl to gles 3.0 or higher, not modifying the source code.

Btw, to comply with the MIT license, you must at least display the copyright and copy the license file. However, the nvg project does not have a license file or source file license headers(I'm sorry if I missed), it cannot meet the requirements for legal use of source code licensed under the MIT license.

@sunli829 I’m sorry to bother you. could you please take the time to add the license file to this project?

@dudochkin-victor
Copy link
Author

Hi.

I want to embed NVG directly into UX-DX because it is a UX-DX concept. UX-DX works in such a way that while the application is running, it can choose the best strategy for the job. For example, if the hardware is running GLES 2.0, the corresponding shaders and calls will be used. If the hardware allows GLES 3.0+ to run, then the GLSL version changes accordingly with all the ensuing consequences, such as UBO buffers. Therefore, I still need to change the code and shaders, albeit a little.

But UX-DX has MPL license.
How do you feel about the fact that your code will be under the MPL license?

Naturally, I will note the mention of the original project. If suddenly you have a desire, then join what I am doing, I will be very happy about it.
All in all, thank you very much for this wonderful job.

@tasogare3710
Copy link

But UX-DX has MPL license.
How do you feel about the fact that your code will be under the MPL license?

I'm not a lawyer, but...

The MPL is distinctly different from earlier OSS licenses in that it licenses each file individually. there is no need to relicense MIT-licensed derivatives with the MPL when combining MPL-licensed source code with MIT-licensed derivatives. It is still licensed by MIT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants