CS598-DLH Bonus Points PR for Text2MolDataset with text2mol_dataset.py #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycq091044
reviewed
Apr 17, 2024
There was a problem hiding this comment.
Thanks for the PR @darinz.
I have tested the PR, which runs successfully. The PR alone is great! You do not have to modify anything and we will give bonus points to you.
Generally, we would ask all new dataset classes to inherit from pyhealth based dataset class. However, we have not finished the multi-modality base dataset yet (@zzachw is working on that), so the PR will be left here and could be merged into master branch once we have multi-modality supports for it.
|
Merged into 240506-sp24-course-pr for now. Will need to refactor based on pyhealth base dataset @zzachw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting PR for New dataset (10 points) bonus points for CS598-DLH class. The new dataset is Text2MolDataset.