Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only raise a warning, not an error for privileged ports #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matt-allan
Copy link

@matt-allan matt-allan commented Aug 2, 2021

On MacOS, on Linux if using authbind, and maybe other cases I don't know about, you don't actually need to use sudo to bind to ports < 1024. However when I try to bind to port 80, Node Foreman raises an error. If I prevent Node Foreman from throwing an error it works fine.

Since we can't detect if this system will or will not require sudo we can just raise a warning instead. We could omit the warning entirely but it might be harder to diagnose the issue if you your system does require sudo?

The use case for me is running a local webserver on port 80 and not having to enter a sudo password every time or unnecessarily elevate permissions.

I've been working around the issue by using a different environment variable to pass the PORT through, but that's pretty confusing for everyone else on the team 😁

I'm having trouble finding a reference for the MacOS guidelines; this is the best I could find: https://news.ycombinator.com/item?id=18302380

On MacOS (and on Linux if using authbind) you don't actually need
to use sudo to bind to ports < 1024, so node-foreman does not need
to raise an error if that happens. Since we can't detect if this
system will or will not require sudo we can just raise a warning.

Signed-off-by: Matthew Allan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant