Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: glob patterns are relative to the config file. #921

Merged
merged 5 commits into from
Feb 10, 2021
Merged

feat: glob patterns are relative to the config file. #921

merged 5 commits into from
Feb 10, 2021

Conversation

Jason3S
Copy link
Collaborator

@Jason3S Jason3S commented Feb 5, 2021

At the moment, the glob patterns are not consistently checked. The VS Code extension and the cspell cli have slightly different rules (they provide different roots). This leads to unnecessary **/ being added to patterns as well as patterns not matching when they should.

Feature:

  1. Glob patterns shall be considered relative to the file they are defined in.
  2. It is possible to define a globRoot to override the default behavior. If globRoot is undefined it will default to the location of the configuration file. globRoot can be relative to the file location. If a project/.settings/cspell.json file has a globRoot of .., then the globRoot will become project. To have the root be the current working directory, use ${cwd}.
  3. It is also possible to define a root for each glob pattern.

@Jason3S Jason3S changed the title feat: glob patterns are relative to the config file. [WIP] feat: Part 1 - glob patterns are relative to the config file. Feb 10, 2021
@Jason3S Jason3S merged commit a250448 into master Feb 10, 2021
@Jason3S Jason3S deleted the dev branch February 10, 2021 11:28
@Jason3S Jason3S changed the title feat: Part 1 - glob patterns are relative to the config file. feat: glob patterns are relative to the config file. Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant