fix: fix #1807 #1837
Merged
fix: fix #1807 #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mad-gooze
approved these changes
Oct 5, 2021
| @@ -44,12 +44,14 @@ export class DiskCache implements CSpellLintResultCache { | |||
|
|
|||
| // Skip reading empty files and files without lint error | |||
| const hasErrors = meta.result.errors > 0 || meta.result.configErrors > 0 || meta.result.issues.length > 0; | |||
| const shouldReadFile = meta.size !== 0 && hasErrors; | |||
| const cached = !!meta.size; | |||
There was a problem hiding this comment.
I think this should be called nonEmpty for readbility?
There was a problem hiding this comment.
It is communicating to the cache consumer that the entry was cached. How that calculation is done is up to the cache itself. It is possible that cached = true might be the correct thing and restore the original shouldReadFile calculation. It is still not clear to me under which situations meta.size will be 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure files are counted, even if they are cached.