New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing reliance on environmental variable #24

Closed

vickychudinov opened this issue Jul 13, 2023 · 1 comment

Assignees

Collaborator

vickychudinov commented Jul 13, 2023

Its not really secure, and its a pain in the ass. I would make the api key a mandatory argument (so no possibility for None), and then if I have my own script where Im implementing this, there I would add the os.environ. But I wouldnt want the library to depend on that.
https://github.com/stoyan-stoyanov/llmflows/blob/6ce79a8cc3b06e799d2b6eb6f6e8e78354f68dcd/llmflows/llms/openai_chat.py#L61C5-L61C5

Owner

stoyan-stoyanov commented Jul 16, 2023

Agree - and done

stoyan-stoyanov self-assigned this

stoyan-stoyanov closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment