Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it be better if these two ifs are an AND statement? #20

Closed
vickychudinov opened this issue Jul 13, 2023 · 1 comment
Closed

Would it be better if these two ifs are an AND statement? #20

vickychudinov opened this issue Jul 13, 2023 · 1 comment

Comments

@vickychudinov
Copy link
Collaborator

On one hand you will make it a little more shallow, on the other - a little more difficult to read

if self.message_prompt_template:

@stoyan-stoyanov
Copy link
Owner

closing as it's no longer the case after moving the logic to MessageHistory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants