-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: why not using the setter? #13
Comments
I am looking into changing this class significantly based on some requirements around ChatFlowStep and persisting conversation history. |
I moved the message management logic out of the OpenAIChat class into a MessageHistory class. Any feedback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
llmflows/llmflows/llms/openai_chat.py
Line 96 in 6ce79a8
I see you have a
@setter
for the conversation history: why do you have another function as well, and why now the message is notdict
but astr
instead? I find this a bit confusing with regard to consistency.The text was updated successfully, but these errors were encountered: