Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] improve fast reload by refactoring to use function components #179

Closed
dannyhw opened this issue Jun 1, 2021 · 4 comments
Closed
Labels

Comments

@dannyhw
Copy link
Member

dannyhw commented Jun 1, 2021

Based on the react native documentation fast reload works best for function components and will use a full reload for class components. By converting to function components we might be able to improve the fast reload experience.

@lauriharpf
Copy link
Contributor

If this work helps get 6.0 out, I would be interested in giving it a go. Made #187 as an example to check understanding of the task & your interest in getting contributions for this.

#186 and my lack of familiarity with the codebase hinder the ability to spot regressions, so some QC would be necessary.

@dannyhw
Copy link
Member Author

dannyhw commented Jun 25, 2021

@lauriharpf for sure you're welcome to take on this issue. Happy to have your contribution 🙂 .

I'll happily provide any assistance and test your changes as required. If you want to discuss anything we can do it here or you can find me in the react native channel of the storybook discord.

@lauriharpf
Copy link
Contributor

@lauriharpf for sure you're welcome to take on this issue. Happy to have your contribution 🙂 .

Thank you! 🙂

Had some spare time and felt like it, so continued this a bit in #189 . Also pushed some minor changes to #187. Joined the discord, let's sync up here or there as needed 👍 .

@dannyhw
Copy link
Member Author

dannyhw commented Jul 11, 2021

This work was completed by @lauriharpf 🙏 . Closing this issue.

@dannyhw dannyhw closed this as completed Jul 11, 2021
@dannyhw dannyhw added this to the 6.0.0-alpha.0 milestone Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants