-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.0] improve fast reload by refactoring to use function components #179
Comments
If this work helps get 6.0 out, I would be interested in giving it a go. Made #187 as an example to check understanding of the task & your interest in getting contributions for this. #186 and my lack of familiarity with the codebase hinder the ability to spot regressions, so some QC would be necessary. |
@lauriharpf for sure you're welcome to take on this issue. Happy to have your contribution 🙂 . I'll happily provide any assistance and test your changes as required. If you want to discuss anything we can do it here or you can find me in the react native channel of the storybook discord. |
Thank you! 🙂 Had some spare time and felt like it, so continued this a bit in #189 . Also pushed some minor changes to #187. Joined the discord, let's sync up here or there as needed 👍 . |
This work was completed by @lauriharpf 🙏 . Closing this issue. |
Based on the react native documentation fast reload works best for function components and will use a full reload for class components. By converting to function components we might be able to improve the fast reload experience.
The text was updated successfully, but these errors were encountered: