From 2406e4ef7cccaaa45d47b250c67a39a49c21ad92 Mon Sep 17 00:00:00 2001
From: raychanks <34273644+raychanks@users.noreply.github.com>
Date: Thu, 13 Jan 2022 21:46:53 +0800
Subject: [PATCH] Revert "fix: defer change update for number input (#291)"
This reverts commit 1f9700354d7e148d6cf8e1dd24585366adc151c9.
---
addons/ondevice-controls/src/PropForm.tsx | 10 ++--------
addons/ondevice-controls/src/types/Number.tsx | 12 +-----------
2 files changed, 3 insertions(+), 19 deletions(-)
diff --git a/addons/ondevice-controls/src/PropForm.tsx b/addons/ondevice-controls/src/PropForm.tsx
index a808e9c915..7f20258e1d 100644
--- a/addons/ondevice-controls/src/PropForm.tsx
+++ b/addons/ondevice-controls/src/PropForm.tsx
@@ -1,7 +1,5 @@
-import React, { memo } from 'react';
+import React from 'react';
import { View } from 'react-native';
-import deepEqual from 'deep-equal';
-
import { ArgTypes } from './ControlsPanel';
import PropField from './PropField';
@@ -27,8 +25,4 @@ const PropForm = ({ args, onFieldChange }: FormProps) => {
);
};
-const deepStrictEqual = (a: any, b: any): boolean => {
- return deepEqual(a, b, { strict: true });
-};
-
-export default memo(PropForm, deepStrictEqual);
+export default PropForm;
diff --git a/addons/ondevice-controls/src/types/Number.tsx b/addons/ondevice-controls/src/types/Number.tsx
index f6f818d8d3..cc9905fe57 100644
--- a/addons/ondevice-controls/src/types/Number.tsx
+++ b/addons/ondevice-controls/src/types/Number.tsx
@@ -26,10 +26,6 @@ export interface NumberProps {
onChange: (value: number) => void;
}
-const replaceComma = (value: number | string): string => {
- return typeof value === 'string' ? value.trim().replace(/,/, '.') : value.toString();
-};
-
const NumberType = ({ arg, onChange = (value) => value }: NumberProps) => {
const showError = Number.isNaN(arg.value);
const [numStr, setNumStr] = useState(arg.value.toString());
@@ -46,7 +42,7 @@ const NumberType = ({ arg, onChange = (value) => value }: NumberProps) => {
value }: NumberProps) => {
);
};
- useEffect(() => {
- return () => {
- onChange(numStrRef.current);
- };
- }, [onChange]);
-
return {arg.range ? renderRange() : renderNormal()};
};