Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 OuputPath property is not set for project 'SQLite3.UWP.vcxproj' #599

Closed
andreujuanc opened this issue Dec 21, 2016 · 8 comments
Closed

Comments

@andreujuanc
Copy link

This should not be closed, as it mean that it's fixed, and it's not:
#592

Manually changing the project file from:
<PlatformToolset>v141</PlatformToolset>
to
<PlatformToolset>v140</PlatformToolset>

Does fix the problem.

Because that issue was closed, i spend some time thinking it was something on my side debugging the project, and in reality (or at least i think that) the issue is not yet fixed.

@brodycj
Copy link
Contributor

brodycj commented Dec 21, 2016

Thanks @andreujuanc for reporting this. From #580 I got agreement with @vladimir-kotikov that we should use an engines specification in package.json that automatically uses an edge branch (cordova-sqlite-storage 2.0.x) in case you use a newer version of Cordova. This is a trick that solves the problem for people who use the Visual Studio GUI.

Unfortunately this trick causes a problem for people who use a newer version of Cordova with the CLI and Visual Studio 2015.

I think the right thing is to tell people to use the following to install the correct version for Visual Studio 2015:

cordova plugin add cordova-sqlite-storage@latest --save

I will document this as soon as I get a chance.

@andreujuanc
Copy link
Author

@brodybits Thanks!! Will do.

@samized
Copy link

samized commented Feb 9, 2017

I am using the latest cordova-sqlite-storage plugin (2.0.2) but the generated SQLite3.UWP.vcxproj File still has <PlatformToolset>v141</PlatformToolset> on every platform configuration. So my build fails without manually changings.

I use Ionic and VS Code.

@brodycj
Copy link
Contributor

brodycj commented Feb 9, 2017

@samized I don't think you quite followed the instructions I gave above.

@samized
Copy link

samized commented Feb 9, 2017

Ok, you mean I should use version 1.5.2 which is fine... I think I run into #632 :/

@brodycj
Copy link
Contributor

brodycj commented Mar 23, 2017

Further discussion will be in #615. Support for Visual Studio 2015 will be dropped soon (will still be supported by Cordova-sqlite-legacy-build-support).

@brodycj brodycj closed this as completed Mar 23, 2017
@andreujuanc
Copy link
Author

andreujuanc commented Mar 23, 2017

Downloading VS2017 in 3..2..1.. 👍
Jokes aside. @brodybits If i cant upgrade right now to VS17, should I move to legacy? Whats the recommendation here? I´m in the middle of project deployment, and cant risk to change tools now.

Cheers

@brodycj
Copy link
Contributor

brodycj commented Mar 24, 2017

If i cant upgrade right now to VS17, should I move to legacy?

Yes, I would recommend it. I will continue to support the legacy version in case of major bug fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants