Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for Nucleo-F439ZI #2347

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

pmantoine
Copy link
Contributor

@pmantoine pmantoine commented Apr 21, 2024

  • Variant files for Nucleo-F439ZI device support

Closing issues

Fixes #2324

@fpistm fpistm self-requested a review April 21, 2024 10:52
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Apr 21, 2024
@fpistm fpistm added this to the 2.8.0 milestone Apr 21, 2024
README.md Outdated Show resolved Hide resolved
STM32 core based on ST HAL automation moved this from In progress to Needs review Apr 21, 2024
Signed-off-by: pmantoine <[email protected]>
Co-authored-by: Frederic Pillon <[email protected]>
@fpistm
Copy link
Member

fpistm commented Apr 24, 2024

Hi @pmantoine
I've updated your PR to declare the board in the boards.txt. And also avoid variant_. duplication.

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

STM32 core based on ST HAL automation moved this from Needs review to Reviewer approved Apr 24, 2024
@fpistm fpistm merged commit d5ee712 into stm32duino:main Apr 24, 2024
24 checks passed
STM32 core based on ST HAL automation moved this from Reviewer approved to Done Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Nucleo-F439ZI support
2 participants