Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: library: EEPROM: use correct flash size #1445

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jul 13, 2021

FLASH_SIZE defined by the CMSIS Device Peripheral Access Layer Header File is the maximum one of a product line.
So depending of the mcu this is not the correct one.

As an example, L432KC have 256 KB while L432Kb has 128 KB.

Using LL_GetFlashSize() allows to get the correct FLASH size.

Fixes #1316

FLASH_SIZE defined by the CMSIS Device Peripheral Access Layer Header File
is the maximum one of a product line.
So depending of the mcu this is not the correct one.

As an example, L432KC have 256 KB while L432Kb has 128 KB.

Using LL_GetFlashSize() allows to get the correct FLASH size.

Fixes stm32duino#1316

Signed-off-by: Frederic Pillon <[email protected]>
@fpistm fpistm added this to In progress in STM32duino libraries via automation Jul 13, 2021
@fpistm fpistm added this to the 2.x.x milestone Jul 13, 2021
@fpistm fpistm requested a review from ABOSTM July 13, 2021 12:54
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

STM32duino libraries automation moved this from In progress to Reviewer approved Jul 13, 2021
@fpistm fpistm merged commit f4f0f81 into stm32duino:master Jul 13, 2021
STM32duino libraries automation moved this from Reviewer approved to Done Jul 13, 2021
@fpistm fpistm deleted the EEPROM_Flash_Size branch July 13, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Wrong flash size for eeprom emulation
2 participants